[llvm] r217629 - [CodeGenPrepare] Teach the addressing mode matcher how to promote zext.

Quentin Colombet qcolombet at apple.com
Tue Sep 16 15:46:30 PDT 2014


Hi Joerg,

This should be fixed by r217926.

Thanks again for the test case.
-Quentin
> On Sep 16, 2014, at 1:45 PM, Quentin Colombet <qcolombet at apple.com> wrote:
> 
>> 
>> On Sep 16, 2014, at 1:41 PM, Quentin Colombet <qcolombet at apple.com> wrote:
>> 
>> 
>>> On Sep 16, 2014, at 12:28 PM, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
>>> 
>>> On Thu, Sep 11, 2014 at 09:22:14PM -0000, Quentin Colombet wrote:
>>>> Author: qcolombet
>>>> Date: Thu Sep 11 16:22:14 2014
>>>> New Revision: 217629
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=217629&view=rev
>>>> Log:
>>>> [CodeGenPrepare] Teach the addressing mode matcher how to promote zext.
>>>> I.e., teach it about 'sext (zext a to ty) to ty2' => zext a to ty2.
>>> 
>>> More fun, again, build with -O2.
>> 
>> Nice!
>> This one is funny, we have in the IR 'zext i8 undef to i32’, which when it is promoted gives a constant 0 instead of ‘zext i8 undef to i64’ (because of how the IRBuilder works).
> 
> And the problem is that we expect an instruction, not a value!
> 
>> I do not know why it is valid to have 'zext i8 undef to i32’ and not 'zext i8 undef to i64’… It looks to me we shouldn’t have ''zext i8 undef to i32’ in the first place.
>> 
>> Looking.
>> 
>> -Quentin
>> 
>>> 
>>> Joerg
>>> <cvt-double-fd672c.c>_______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
>> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140916/4a3908e3/attachment.html>


More information about the llvm-commits mailing list