[PATCH] Turn local DWARFContext helpers getFileNameForUnit() and getFileLineInfoForCompileUnit() into full-blowm DWARFDebugLine::LineTable methods.

Frederic Riss friss at apple.com
Tue Sep 16 09:40:28 PDT 2014


As per review comments:
 - Remove DWARFUnit * parameters to LineTable methods. Pass just the compilation dir instead.
 - Remove useless temporaries in getFileNameByIndex
 - Change the order of getFileNameByIndex arguments to be more natural

With above changes, the name getFileLineInfoForCompilationUnit didn't make any sense anymore (no more CU argument). Rename the function to getFileLineInfoForAddress instead.

http://reviews.llvm.org/D5354

Files:
  lib/DebugInfo/DWARFContext.cpp
  lib/DebugInfo/DWARFDebugLine.cpp
  lib/DebugInfo/DWARFDebugLine.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5354.13754.patch
Type: text/x-patch
Size: 8740 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140916/9229694d/attachment.bin>


More information about the llvm-commits mailing list