[llvm] r217871 - Make DWARFUnitSection final and change base class to non-virtual protected destructor.

Frederic Riss friss at apple.com
Tue Sep 16 05:58:02 PDT 2014


Author: friss
Date: Tue Sep 16 07:58:01 2014
New Revision: 217871

URL: http://llvm.org/viewvc/llvm-project?rev=217871&view=rev
Log:
Make DWARFUnitSection final and change base class to non-virtual protected destructor.

As per dblaikie suggestion.

Modified:
    llvm/trunk/lib/DebugInfo/DWARFUnit.h

Modified: llvm/trunk/lib/DebugInfo/DWARFUnit.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFUnit.h?rev=217871&r1=217870&r2=217871&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/DWARFUnit.h (original)
+++ llvm/trunk/lib/DebugInfo/DWARFUnit.h Tue Sep 16 07:58:01 2014
@@ -36,13 +36,14 @@ public:
   /// same section this Unit originated from.
   virtual DWARFUnit *getUnitForOffset(uint32_t Offset) const = 0;
 
-  virtual ~DWARFUnitSectionBase() {}
+protected:
+  ~DWARFUnitSectionBase() {}
 };
 
 /// Concrete instance of DWARFUnitSection, specialized for one Unit type.
 template<typename UnitType>
-class DWARFUnitSection : public SmallVector<std::unique_ptr<UnitType>, 1>,
-                         public DWARFUnitSectionBase {
+class DWARFUnitSection final : public SmallVector<std::unique_ptr<UnitType>, 1>,
+                               public DWARFUnitSectionBase {
 
   struct UnitOffsetComparator {
     bool operator()(const std::unique_ptr<UnitType> &LHS,





More information about the llvm-commits mailing list