[llvm] r217842 - DebugInfo: Add comment describing the need to disable address pool usage in skeleton units.

[David Blaikie]

Author: dblaikie
Date: Mon Sep 15 17:41:25 2014
New Revision: 217842

URL: http://llvm.org/viewvc/llvm-project?rev=217842&view=rev
Log:
DebugInfo: Add comment describing the need to disable address pool usage in skeleton units.

Post commit review from Eric Christopher.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=217842&r1=217841&r2=217842&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp Mon Sep 15 17:41:25 2014
@@ -286,6 +286,11 @@ void DwarfUnit::addSectionOffset(DIE &Di
 void DwarfCompileUnit::addLabelAddress(DIE &Die, dwarf::Attribute Attribute,
                                        const MCSymbol *Label) {
 
+  // Don't use the address pool in non-fission or in the skeleton unit itself.
+  // FIXME: Once GDB supports this, it's probably worthwhile using the address
+  // pool from the skeleton - maybe even in non-fission (possibly fewer
+  // relocations by sharing them in the pool, but we have other ideas about how
+  // to reduce the number of relocations as well/instead).
   if (!DD->useSplitDwarf() || !Skeleton)
     return addLocalLabelAddress(Die, Attribute, Label);