[llvm] r217747 - Introduce the DWARFUnitSection abstraction.

[Frédéric Riss]

> On 15 Sep 2014, at 12:26, Chandler Carruth <chandlerc at google.com> wrote:
> 
> 
> On Mon, Sep 15, 2014 at 3:23 AM, Frédéric Riss <friss at apple.com <mailto:friss at apple.com>> wrote:
> This is obviously true, but I don’t see it with my system clang version, and I didn’t see it on any on the bots I looked at. Maybe it will show up in later bootstrap builds that will use trunk clang.
> 
> As I need pre-commit review to get the fix in, do you want me to revert the change now?
> 
> Whaaa? No no, you don't need pre-commit review to fix a problem pointed out by a warning. =D Please just commit the fix if you have it. If not, I'll commit it shortly so my builds are tidied up.

Oh, I wasn’t talking about just your warning. I was talking about the inheritance removal which is a bit bigger. For your warning, I can add an empty virtual destructor to the base class, and hope it fixes the issue for you. I’ll try to reproduce it first.

> I’ll submit the code removing the inheritance later today, but I can’t presume of the review time.
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140915/09034512/attachment.html>