[llvm] r217747 - Introduce the DWARFUnitSection abstraction.

[Chandler Carruth]

On Mon, Sep 15, 2014 at 2:58 AM, Frédéric Riss <friss at apple.com> wrote:

> On 15 Sep 2014, at 11:51, Chandler Carruth <chandlerc at google.com> wrote:
>
>
> On Mon, Sep 15, 2014 at 12:50 AM, Frederic Riss <friss at apple.com> wrote:
>
>> +/// Base class for all DWARFUnitSection classes. This provides the
>> +/// functionality common to all unit types.
>> +class DWARFUnitSectionBase {
>> +public:
>> +  /// Returns the Unit that contains the given section offset in the
>> +  /// same section this Unit originated from.
>> +  virtual DWARFUnit *getUnitForOffset(uint32_t Offset) const = 0;
>>
>
> This, through every instantiation of the below template:
>
>
>> +};
>> +
>> +/// Concrete instance of DWARFUnitSection, specialized for one Unit type.
>> +template<typename UnitType>
>> +class DWARFUnitSection : public SmallVector<std::unique_ptr<UnitType>,
>> 1>,
>> +                         public DWARFUnitSectionBase {
>>
>
> Is causing *massive* spews of warnings. =/
>
>
> Sorry about that, I’m not seeing anything here… what kind of warnings?
> There was an ambiguous type aliasing issue that I corrected in r217751
> (only diagnosed by GCC btw).
>

../lib/DebugInfo/DWARFUnit.h:33:7: warning: 'llvm::DWARFUnitSectionBase'
has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]

Not sure if I have a busted compiler, but I'm self hosting with Clang...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140915/e8daae38/attachment.html>