[PATCH] Add preload method.

Rui Ueyama ruiu at google.com
Sun Sep 14 20:24:46 PDT 2014


On Sat, Sep 13, 2014 at 11:26 PM, Shankar Kalpathi Easwaran <
shankarke at gmail.com> wrote:

> a) The undefined symbol could very well be in a shared library or a
> regular ELF object, which is already parsed by a thread.
> b) There might be more than one archive library or a .o that would have
> the same symbol name.
> c) Weak symbol resolution has to be taken care as well, as the symbol name
> would be the same, and symbols may be picked up from a different archive on
> how the weak symbol was resolved.
> d) The inputGraph is agnostic to what input in the graph contains the
> symbol name.
>

All the above points make sense but they would be handled well in my
approach. I guess you just pointed out the things that we have to consider?

We could have a background thread, that could be designated to **only parse
> archive** files by looking at undefined symbols.
>

That's what I'm proposing.

What do you think ?
>
> ================
> Comment at: include/lld/Core/InputGraph.h:85
> @@ +84,3 @@
> +  /// file is requested from the core linker we can respond to it quickly.
> +  /// It does not change the meaining of the code. In particualr this
> +  /// function should not have any observable side effect.
> ----------------
> spell errors.
>
> http://reviews.llvm.org/D5340
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140914/45441cb4/attachment.html>


More information about the llvm-commits mailing list