[PATCH] Rename getNoopForMachoTarget to getNoop

[Brad Smith]

On 14/09/14 9:00 AM, Joerg Sonnenberger wrote:
> On Sat, Sep 13, 2014 at 06:39:04PM -0400, Brad Smith wrote:
>> On 13/09/14 5:43 PM, Brad Smith wrote:
>>> On 13/09/14 5:20 PM, Joerg Sonnenberger wrote:
>>>> On Sat, Sep 13, 2014 at 01:22:58PM -0400, Brad Smith wrote:
>>>>> Here is a patch to rename getNoopForMachoTarget to getNoop.
>>>>
>>>> If we want to keep it like that, it should be abstract to make sure
>>>> every target implements it.
>>>
>>> That is already the case as it is.
>>
>> To clarify... every target has to implement it as it is already.
>
> But the existance of the inline default means that we don't find
> platforms not implementing it until runtime. Given that we are pretty
> much settled on MC now, that seems like an unneecessary pitfall.

Oh I fully agree with that. I think it's a bad idea that targets
are only running into this issue at run-time.

But that would have to be a second diff down the road after the
other targets implement a function for each respective target still
missing the function, no?

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.