[llvm] r217655 - Remove a temporary variable and just construct a unique_ptr directly using make_unique.

Craig Topper craig.topper at gmail.com
Thu Sep 11 22:17:20 PDT 2014


Author: ctopper
Date: Fri Sep 12 00:17:20 2014
New Revision: 217655

URL: http://llvm.org/viewvc/llvm-project?rev=217655&view=rev
Log:
Remove a temporary variable and just construct a unique_ptr directly using make_unique.

Modified:
    llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp

Modified: llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp?rev=217655&r1=217654&r2=217655&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp (original)
+++ llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp Fri Sep 12 00:17:20 2014
@@ -304,14 +304,12 @@ public:
     setAvailableFeatures(ComputeAvailableFeatures(STI.getFeatureBits()));
     
     // Remember the initial assembler options. The user can not modify these.
-    MipsAssemblerOptions *TmpAOPtr = 
-      new MipsAssemblerOptions(getAvailableFeatures());
-    AssemblerOptions.push_back(std::unique_ptr<MipsAssemblerOptions>(TmpAOPtr));
+    AssemblerOptions.push_back(
+                     make_unique<MipsAssemblerOptions>(getAvailableFeatures()));
     
     // Create an assembler options environment for the user to modify.
-    TmpAOPtr = new MipsAssemblerOptions(getAvailableFeatures());
-    AssemblerOptions.push_back(std::unique_ptr<MipsAssemblerOptions>(TmpAOPtr));
-    TmpAOPtr = nullptr;
+    AssemblerOptions.push_back(
+                     make_unique<MipsAssemblerOptions>(getAvailableFeatures()));
 
     getTargetStreamer().updateABIInfo(*this);
 
@@ -2700,9 +2698,8 @@ bool MipsAsmParser::parseSetPushDirectiv
     return reportParseError("unexpected token, expected end of statement");
 
   // Create a copy of the current assembler options environment and push it.
-  MipsAssemblerOptions *TmpAOPtr = 
-    new MipsAssemblerOptions(AssemblerOptions.back().get());
-  AssemblerOptions.push_back(std::unique_ptr<MipsAssemblerOptions>(TmpAOPtr));
+  AssemblerOptions.push_back(
+              make_unique<MipsAssemblerOptions>(AssemblerOptions.back().get()));
 
   getTargetStreamer().emitDirectiveSetPush();
   return false;





More information about the llvm-commits mailing list