[PATCH] Add -bare option to llvm-objdump

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Sep 11 11:51:07 PDT 2014


>>> Symbolization is the default, -bare turns it off.
>>
>> On which platform?
>>
>
> All platforms.

No, I mean, on which platform the system objdump has a -bare option?

>> That is a general statement, I don't think it applies in here. Most checks
>> using llvm-objdump don't seem to be looking a at jmp or a call which
>> would be changed with symbolization.
>
>
> Yes, but looking beyond jmp/call symbolizing?  For example, Sean's wish list?

One item at a time.

>> IMHO each feature is a different case. In the case of symbolization, as you
>> mentioned it is *always* enabled on every platform. So in this case I think
>> we should follow the system default: always enable symbolization in
>> llvm-objdump.
>
>
> In other words, no -bare option.

Correct.

> The patch shows 66 tests that use disassembly in some way.  I have no
> feel for how many will break or the time investment to fix each
> problem.  Should I just try jmp/call symbolization and see how it
> goes?

That is my suggestion, yes.

Cheers,
Rafael



More information about the llvm-commits mailing list