[PATCH] Add -bare option to llvm-objdump

Steve King steve at metrokings.com
Wed Sep 10 15:03:12 PDT 2014


On Wed, Sep 10, 2014 at 2:14 PM, Sean Silva <chisophugis at gmail.com> wrote:
>
> On Wed, Sep 10, 2014 at 1:38 PM, Steve King <kingshizzle at gmail.com> wrote:
>>
>> The -bare option keeps objdump output consistent with test expectations
>> regardless of host platform.  As discussed on the list, default llvm-objdump
>> output could change per host:  GNU style for Linux, otools for Apple, etc.
>
>
> I think this needs some discussion in LLVMDev. I don't see the point in
> slaving to reproduce the system tool's output when we don't match the
> command-line options.
>

Command line mismatch is a good point.  IMHO, matching the commonly
used command line knobs and typical output style would be good enough.
I've helped colleagues with llvm-objdump vs. GNU objdump on one past
project already and the bar isn't that high.  The -bare option at
least opens the door to per-host defaults.

One a practical note, analyzing llvm-objdump test failures is labor
intensive and a bit nerve wracking since i'm not familiar with many of
the target architectures.  The -bare option allows us to change output
in purely aesthetic ways without breaking tests.



More information about the llvm-commits mailing list