[PATCH] Fix assertion in LICM doFinalization()

David Peixotto dpeixott at codeaurora.org
Wed Sep 10 17:46:44 PDT 2014


The doFinalization method checks that the LoopToAliasSetMap is
empty. LICM populates that map as it runs through the loop nest,
deleting the entries for child loops as it goes. However, if a child
loop is deleted by another pass (e.g. unrolling) then the loop will
never be deleted from the map because LICM walks the loop nest to
find entries it can delete.

The fix is to delete the loop from the map and free the alias set
when the loop is deleted from the loop nest.

http://reviews.llvm.org/D5305

Files:
  include/llvm/Analysis/LoopPass.h
  lib/Analysis/LoopPass.cpp
  lib/Transforms/Scalar/LICM.cpp
  test/Transforms/LICM/2014-09-10-doFinalizationAssert.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5305.13569.patch
Type: text/x-patch
Size: 3953 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140911/4bd2df54/attachment.bin>


More information about the llvm-commits mailing list