[patch] Add doInitialization/doFinalization to DataLayoutPass

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Sep 10 12:34:08 PDT 2014


Dmitri noticed that in r202168 doFinalization got dropped from the
DataLayoutPass.

If we are going to add it back, it is probably a good idea to add
doInitialization too. With that a DataLayoutPass can be reused for
multiple modules.

Once we have doInitialization/doFinalization, it doesn't seem
necessary to pass a Module to the constructor.

Overall this change seems in line with the idea of making DataLayout a
required part of Module. With it the only way of having a DataLayout
used is to add it to the Module.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 12264 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140910/31416ce1/attachment.bin>


More information about the llvm-commits mailing list