[PATCH 8/8] R600: Add cmpxchg instruction for evergreen

Matt Arsenault arsenm2 at gmail.com
Wed Sep 10 11:24:39 PDT 2014


On Sep 9, 2014, at 6:06 PM, Aaron Watry <awatry at gmail.com> wrote:

> 
> -      if (!MRI.use_empty(MI->getOperand(DstIdx).getReg()))
> +      if (!MRI.use_empty(MI->getOperand(DstIdx).getReg()) || MI->getOpcode() == AMDGPU::LDS_CMPST_RET)
>         return BB;

These all LGTM, except this checking for a specific opcode looks hacky. This at least should have a FIXME comment about why it’s here
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140910/f638cd01/attachment.html>


More information about the llvm-commits mailing list