[PATCH] Select Elimination in InstCombine

[Chandler Carruth]

On Tue, Sep 9, 2014 at 3:01 PM, Hal Finkel <hfinkel at anl.gov> wrote:

> > The problem with making DT optional is that you might never get it.
> > If any pass that runs before InstCombine invalidates DT, it won’t be
> > available to any following pass until there is a pass that
> > explicitly requires it.
>
> That's true. There have been objections in the past to making it required,
> and I don't recall by whom or why exactly. In the current standard pass
> manager configuration, it does happen at least once.


Just to reiterate what I said in the code review, I actually agree with
Juergen, but I think it would be fine to make it required. I just want to
get the business logic into instcombine right away, and then double check
that the compile time is OK when we make DT required.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140909/0332420b/attachment.html>