[PATCH] Add aliases for VAND imm to VBIC ~imm

Tim Northover t.p.northover at gmail.com
Tue Sep 9 06:30:33 PDT 2014


================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:2409
@@ +2408,3 @@
+private:
+  unsigned validateNEONi16splatOperands(unsigned Value) const {
+    if (Value >= 256)
----------------
rengolin wrote:
> t.p.northover wrote:
> > This isn't really a validation (which implies it might be invalid). Perhaps an "encodeNEON..."; if so, it should probably go into MCTargetDesc with the others.
> encode is a better name, yes. Where in MCTargetDesc you're thinking of?
It looks like there's already some utilities for modified NEON values in ARMAddressingModes.h. Just no encode that I could see yet.

http://reviews.llvm.org/D5263






More information about the llvm-commits mailing list