[llvm] r217431 - ARM: Negative offset support problem

[Renato Golin]

Author: rengolin
Date: Tue Sep  9 04:57:59 2014
New Revision: 217431

URL: http://llvm.org/viewvc/llvm-project?rev=217431&view=rev
Log:
ARM: Negative offset support problem

This patch is to permit a negative offset usage for a non frame access.

Patch by Igor Oblakov.

Added:
    llvm/trunk/test/CodeGen/ARM/negative-offset.ll
Modified:
    llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp

Modified: llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp?rev=217431&r1=217430&r2=217431&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMISelDAGToDAG.cpp Tue Sep  9 04:57:59 2014
@@ -542,11 +542,11 @@ bool ARMDAGToDAGISel::SelectAddrModeImm1
   }
 
   if (ConstantSDNode *RHS = dyn_cast<ConstantSDNode>(N.getOperand(1))) {
-    int RHSC = (int)RHS->getZExtValue();
+    int RHSC = (int)RHS->getSExtValue();
     if (N.getOpcode() == ISD::SUB)
       RHSC = -RHSC;
 
-    if (RHSC >= 0 && RHSC < 0x1000) { // 12 bits (unsigned)
+    if (RHSC > -0x1000 && RHSC < 0x1000) { // 12 bits
       Base   = N.getOperand(0);
       if (Base.getOpcode() == ISD::FrameIndex) {
         int FI = cast<FrameIndexSDNode>(Base)->getIndex();

Added: llvm/trunk/test/CodeGen/ARM/negative-offset.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/negative-offset.ll?rev=217431&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/ARM/negative-offset.ll (added)
+++ llvm/trunk/test/CodeGen/ARM/negative-offset.ll Tue Sep  9 04:57:59 2014
@@ -0,0 +1,17 @@
+; RUN: llc -mtriple=arm-eabi -O3 %s -o - | FileCheck %s
+
+; Function Attrs: nounwind readonly
+define arm_aapcscc i32 @sum(i32* nocapture readonly %p) #0 {
+entry:
+;CHECK-LABEL: sum:
+;CHECK-NOT: sub
+;CHECK: ldr r{{.*}}, [r0, #-16]
+;CHECK: ldr r{{.*}}, [r0, #-8]
+  %arrayidx = getelementptr inbounds i32* %p, i32 -4
+  %0 = load i32* %arrayidx, align 4
+  %arrayidx1 = getelementptr inbounds i32* %p, i32 -2
+  %1 = load i32* %arrayidx1, align 4
+  %add = add nsw i32 %1, %0
+  ret i32 %add
+}
+