[PATCH][MIPS] Add aliases for sync instruction used by Octeon CPU

Daniel Sanders Daniel.Sanders at imgtec.com
Tue Sep 9 02:55:49 PDT 2014


The patch LGTM but I'm not sure we should add syncio and syncioall. They don't seem to be in the upstream gas and I found this when I tried searching for them:
	SYNCIO and SYNCIOALL opcodes were removed from the assembler.  These were experimental Octeon-specific instructions that are not supported by any Octeon processors.
	- https://github.com/zerix/Cavium-SDK-2.0/blob/master/release-notes.txt
I'm thinking that we shouldn't add them if they've already been removed from the Cavium SDK and never made it upstream. What's your opinion?

> -----Original Message-----
> From: Kai Nacke [mailto:kai.nacke at redstar.de]
> Sent: 08 September 2014 06:31
> To: Daniel Sanders; llvm-commits
> Subject: Re: [PATCH][MIPS] Add aliases for sync instruction used by Octeon
> CPU
> 
> Ping.
> 
> While checking the Octeon SDK I noticed that gas supports 2 additional
> aliases: syncio and syncioall. I also added them.
> 
> Regards,
> Kai
> 
> On 02.09.2014 19:05, Kai Nacke wrote:
> > Hi Daniel,
> >
> > the attached patch adds aliases for the sync instruction (synciobdma,
> > syncs, syncw, syncws) which are used by the Octeon CPU.
> >
> > Please review.
> >
> > Regards,
> > Kai
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >





More information about the llvm-commits mailing list