[PATCH] [dwarfdump] Implement extraction of file information referenced in .debug_info.

David Blaikie dblaikie at gmail.com
Thu Sep 4 15:28:42 PDT 2014

Please go ahead & commit the decl/call_line portion of this (I'll take your
word for it that these seem like the only ones that should be printed as
decimal, the rest as hex - and if we see other cases we can figure it out
at that point) & then rebase this patch.

The realpath piece of this is particularly interesting - I don't know what
that API is, where it comes from (why it might not always be available),
etc. Also, not sure it makes sense to canonicalize the paths based on the
actual filesystem, rather than just rendering what's in the line table...
maybe some examples would help me understand better. (is that codepath
tested? How do we test it on machines that don't have realpath?)

On Thu, Sep 4, 2014 at 2:37 PM, Frederic Riss <friss at apple.com> wrote:

> Sorry for the spam. I'm still learning to use arcanist, and I must say at
> this point it's more a burden that a help... This latest revision is the
> result of a small series of 3 commits that should be easy enough to
> distinguish. They aren't really intermingled except for the test updates.
> The first just prints the line numbers in decimal and updates the tests.
> The second moves some static helpers of DWARFContext.cpp into equivalent
> methods of LineTable. There should be no functional change though.
> The third one uses the newly exposed method to find and print full names
> for files referenced by DW_AT_(decl|call)_file.
> http://reviews.llvm.org/D5192
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140904/88c0cff8/attachment.html>

More information about the llvm-commits mailing list