[PATCH] [Power] Use AtomicExpandPass for fence insertion, and use lwsync where appropriate

Hal Finkel hfinkel at anl.gov
Thu Sep 4 10:38:37 PDT 2014


----- Original Message -----
> From: "Manuel Klimek" <klimek at google.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: llvm-commits at cs.uiuc.edu, morisset at google.com, jfb at chromium.org
> Sent: Thursday, September 4, 2014 12:37:05 PM
> Subject: Re: [PATCH] [Power] Use AtomicExpandPass for fence insertion, and use lwsync where appropriate
> 
> Did you send another one, or was the one I got the one you originally
> sent?

That was the original, it just took about 120x longer than usual ;)

 -Hal

> 
> 
> On Thu Sep 04 2014 at 9:34:14 AM Hal Finkel < hfinkel at anl.gov >
> wrote:
> 
> 
> Manuel,
> 
> I posted a review to this patch about an hour ago, but I don't think
> a corresponding e-mail made it to the list. Can you please check on
> it?
> 
> Thanks again,
> Hal
> 
> ----- Original Message -----
> > From: "Robin Morisset" < morisset at google.com >
> > To: morisset at google.com , jfb at chromium.org
> > Cc: llvm-commits at cs.uiuc.edu
> > Sent: Wednesday, September 3, 2014 6:23:37 PM
> > Subject: [PATCH] [Power] Use AtomicExpandPass for fence insertion,
> > and use lwsync where appropriate
> > 
> > Hi jfb,
> > 
> > This patch makes use of AtomicExpandPass in Power for inserting
> > fences around
> > atomic as part of an effort to remove fence insertion from
> > SelectionDAGBuilder.
> > As a big bonus, it lets us use sync 1 (lightweight sync, often used
> > by the mnemonic
> > lwsync) instead of sync 0 (heavyweight sync) in many cases.
> > 
> > I also added a test, as there was no test for the barriers emitted
> > by
> > the Power
> > backend for atomic loads and stores.
> > 
> > http://reviews.llvm.org/D5180
> > 
> > Files:
> > include/llvm/IR/ IntrinsicsPowerPC.td
> > lib/Target/PowerPC/ PPCISelLowering.cpp
> > lib/Target/PowerPC/ PPCISelLowering.h
> > lib/Target/PowerPC/ PPCInstrInfo.td
> > lib/Target/PowerPC/ PPCTargetMachine.cpp
> > test/CodeGen/PowerPC/atomics. ll
> > 
> > ______________________________ _________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/ mailman/listinfo/llvm-commits
> > 
> 
> --
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory



More information about the llvm-commits mailing list