[PATCH] CMake+Ninja Linux buildbots

Renato Golin renato.golin at linaro.org
Thu Sep 4 09:47:45 PDT 2014

Hi David,

Thanks for the review! Comments inline...

On 4 September 2014 16:29, David Blaikie <dblaikie at gmail.com> wrote:
> I'd probably avoid introducing a different ordering of the name
> "checkout_clang_extra_tools" (where the repository is clang_tools_extra, etc
> - so just name it "checkout_clang_tools_extra" for consistency)

Of course!

> The stage two part could maybe benefit from an early return rather than
> indenting the whole thing

Good point, will do.

> Other than that it looks like a totally plausible/good start to me.

Great! I'll commit with those changes and build up from there.


More information about the llvm-commits mailing list