[PATCH 1/1] build/cmake: Fix CMP0023 warning with libffi
jan.vesely at rutgers.edu
Thu Sep 4 07:32:45 PDT 2014
On Thu, 2014-09-04 at 13:47 +0100, Dan Liew wrote:
> > thank you both for looking at this.
> > libffi is only used in one file
> > (lib/ExecutionEngine/Interpreter/ExternalFunctions.cpp) and it is never
> > part of the llvm interface.
> Apologies Jan. I appear to have hijacked your thread trying to
> understand some of CMake's new features.
no worries, it's a good oportunitiy to learn how cmake handles this.
> Given that Brad is happy with your patch and that using PRIVATE in
> this case is recommended by CMake's documentation (``Generally, a
> dependency should be specified in a use of target_link_libraries()
> with the PRIVATE keyword if it is used by only the implementation of a
> library``) the patch should be fine to commit.
> Do you have commit access? If not let me know and I can commit on your behalf.
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: This is a digitally signed message part
More information about the llvm-commits