[llvm] r217128 - Add a DWARFContext& member in DWARFUnit.

David Blaikie dblaikie at gmail.com
Thu Sep 4 06:15:24 PDT 2014


On Sep 4, 2014 12:15 AM, "Frédéric Riss" <friss at apple.com> wrote:
>
>
>> On 04 Sep 2014, at 08:57, Justin Bogner <mail at justinbogner.com> wrote:
>>
>> Frederic Riss <friss at apple.com> writes:
>>>
>>>
==============================================================================
>>> --- llvm/trunk/lib/DebugInfo/DWARFContext.cpp (original)
>>> +++ llvm/trunk/lib/DebugInfo/DWARFContext.cpp Thu Sep  4 01:14:28 2014
>>> @@ -318,7 +318,7 @@ void DWARFContext::parseCompileUnits() {
>>>   const DataExtractor &DIData = DataExtractor(getInfoSection().Data,
>>>                                               isLittleEndian(), 0);
>>>   while (DIData.isValidOffset(offset)) {
>>> -    std::unique_ptr<DWARFCompileUnit> CU(new DWARFCompileUnit(
>>> +    std::unique_ptr<DWARFCompileUnit> CU(new DWARFCompileUnit(*this,
>>
>>
>> While you're in here, it might be worthwhile to clean these up to use
>> auto and llvm::make_unique.
>
>
> Like so?

Yep

>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140904/dd2334a9/attachment.html>


More information about the llvm-commits mailing list