Add DWARFContext member and accessor to DWARFUnit

[Alexey Samsonov]

On Wed, Sep 3, 2014 at 12:04 PM, David Blaikie <dblaikie at gmail.com> wrote:

>
>
>
> On Wed, Sep 3, 2014 at 11:58 AM, Frédéric Riss <friss at apple.com> wrote:
>
>> No problem, I’ll rebase the series.
>>
>> Is the patch OK with that change? Or do you want to see a patch with a
>> user first ?
>>
>
> I think it'll be fine with that change. I can imagine what sort of users
> will eventually need this.
>

+1
I also considered this change as usable at some point in future.
Also, could you please use http://llvm.org/docs/Phabricator.html for your
patches? Commenting/watching the context is superior there. Thanks.



>
>
>>
>> On 03 Sep 2014, at 20:49, David Blaikie <dblaikie at gmail.com> wrote:
>>
>> Could we pass that by reference instead of pointer, perhaps? (I know
>> there's lots of pointers in the exsting codebase (here and elsewhere), but
>> there's at least some desire to move towards references where
>> practical/reasonable (essentially when rebinding and nullness are not
>> required))
>>
>>
>> On Wed, Sep 3, 2014 at 11:45 AM, Frédéric Riss <friss at apple.com> wrote:
>>
>>> First preparatory patch of the dwarfdump work. No feature or functional
>>> change, just introduce a DWARFContext member in the DWARFUnit that will be
>>> used later to make cross-section accesses or to store global state like
>>> dumping options.
>>>
>>> Ok to go in?
>>>
>>>
>>>
>>>
>>
>>
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>


-- 
Alexey Samsonov
vonosmas at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140903/34ce86a1/attachment.html>