[llvm] r217113 - llvm-cov: Don't pointlessly create a unique_ptr (NFC)

[Justin Bogner]

Author: bogner
Date: Wed Sep  3 19:04:54 2014
New Revision: 217113

URL: http://llvm.org/viewvc/llvm-project?rev=217113&view=rev
Log:
llvm-cov: Don't pointlessly create a unique_ptr (NFC)

There's no ownership going on here, and no reason to heap allocate
this object.

Modified:
    llvm/trunk/tools/llvm-cov/CodeCoverage.cpp

Modified: llvm/trunk/tools/llvm-cov/CodeCoverage.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/CodeCoverage.cpp?rev=217113&r1=217112&r2=217113&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/CodeCoverage.cpp (original)
+++ llvm/trunk/tools/llvm-cov/CodeCoverage.cpp Wed Sep  3 19:04:54 2014
@@ -615,18 +615,17 @@ int CodeCoverageTool::show(int argc, con
       if (findMainViewFileID(Function, MainFileID))
         continue;
       StringRef SourceFile = Function.Filenames[MainFileID];
-      std::unique_ptr<SourceCoverageView> mainView;
       auto SourceBuffer = getSourceFile(SourceFile);
       if (!SourceBuffer)
         return 1;
       auto Range = findExpandedFileInterestingLineRange(MainFileID, Function);
-      mainView.reset(new SourceCoverageView(SourceBuffer.get(), ViewOpts,
-                                            Range.first, Range.second));
-      createSourceFileView(SourceFile, *mainView, Function, true);
+      SourceCoverageView mainView(SourceBuffer.get(), ViewOpts, Range.first,
+                                  Range.second);
+      createSourceFileView(SourceFile, mainView, Function, true);
       ViewOpts.colored_ostream(outs(), raw_ostream::CYAN)
           << Function.PrettyName << " from " << SourceFile << ":";
       outs() << "\n";
-      mainView->render(outs());
+      mainView.render(outs());
       if (FunctionMappingRecords.size() > 1)
         outs() << "\n";
     }
@@ -648,12 +647,11 @@ int CodeCoverageTool::show(int argc, con
   }
 
   for (const auto &SourceFile : SourceFiles) {
-    std::unique_ptr<SourceCoverageView> mainView;
     auto SourceBuffer = getSourceFile(SourceFile);
     if (!SourceBuffer)
       return 1;
-    mainView.reset(new SourceCoverageView(SourceBuffer.get(), ViewOpts));
-    if (createSourceFileView(SourceFile, *mainView, FunctionMappingRecords)) {
+    SourceCoverageView mainView(SourceBuffer.get(), ViewOpts);
+    if (createSourceFileView(SourceFile, mainView, FunctionMappingRecords)) {
       ViewOpts.colored_ostream(outs(), raw_ostream::RED)
           << "warning: The file '" << SourceFile << "' isn't covered.";
       outs() << "\n";
@@ -664,7 +662,7 @@ int CodeCoverageTool::show(int argc, con
       ViewOpts.colored_ostream(outs(), raw_ostream::CYAN) << SourceFile << ":";
       outs() << "\n";
     }
-    mainView->render(outs());
+    mainView.render(outs());
     if (SourceFiles.size() > 1)
       outs() << "\n";
   }