Add DWARFContext member and accessor to DWARFUnit

David Blaikie dblaikie at gmail.com
Wed Sep 3 12:04:53 PDT 2014


On Wed, Sep 3, 2014 at 11:58 AM, Frédéric Riss <friss at apple.com> wrote:

> No problem, I’ll rebase the series.
>
> Is the patch OK with that change? Or do you want to see a patch with a
> user first ?
>

I think it'll be fine with that change. I can imagine what sort of users
will eventually need this.


>
> On 03 Sep 2014, at 20:49, David Blaikie <dblaikie at gmail.com> wrote:
>
> Could we pass that by reference instead of pointer, perhaps? (I know
> there's lots of pointers in the exsting codebase (here and elsewhere), but
> there's at least some desire to move towards references where
> practical/reasonable (essentially when rebinding and nullness are not
> required))
>
>
> On Wed, Sep 3, 2014 at 11:45 AM, Frédéric Riss <friss at apple.com> wrote:
>
>> First preparatory patch of the dwarfdump work. No feature or functional
>> change, just introduce a DWARFContext member in the DWARFUnit that will be
>> used later to make cross-section accesses or to store global state like
>> dumping options.
>>
>> Ok to go in?
>>
>>
>>
>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140903/7d9c696e/attachment.html>


More information about the llvm-commits mailing list