[ dwarfdump ] Add symbolic dump of known DWARF attribute values.

Frédéric Riss friss at apple.com
Wed Sep 3 12:03:45 PDT 2014

> On 03 Sep 2014, at 20:57, Adrian Prantl <aprantl at apple.com> wrote:
>> On Sep 3, 2014, at 11:52 AM, Frédéric Riss <friss at apple.com> wrote:
>> This patch introduces symbolic dump of all the DWARF standard values (defined in Dwarf.h). It requires the previous DWARFFormValue accessor patch. The fixed accessibility test shows that it’s much easier to check that the test is actually correct, rather than having to cross-check with the enumerator value.
>> OK?
>> <dwarfdump-SymbolicAttributes.diff>
> If you look at lib/Support/Dwarf.cpp, there is already a similar switch table for converting all the attribute names. We should probably only have one such implementation.

Really, which one? I see tables converting from various enum to const char * value, but my switch associates DW_AT_* attributes with the corresponding attribute enumeration. This patch uses all the switch functions in Dwarf.cpp, but AFAICS it doesn’t duplicate anything. But maybe I’m looking at the wrong place?


More information about the llvm-commits mailing list