[Patch] Improvements for CMake cross compilation on OS X

Chris Bieneman beanz at apple.com
Wed Sep 3 11:33:11 PDT 2014

Yep… Missed that one. Updated diffs below. Any other feedback or are these good to land?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cross-compile.diff
Type: application/octet-stream
Size: 7965 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140903/21aa767d/attachment.obj>
-------------- next part --------------

> On Sep 3, 2014, at 6:25 AM, Brad King <brad.king at kitware.com> wrote:
> On 09/02/2014 04:56 PM, Chris Bieneman wrote:
>> The iOS support is definitely "Works for Me". My hope is
>> this would also work for Android, but I'm not setup to
>> build for Android.
> I see no reason it shouldn't work for both.
>> How does this revised patch look?
> Good, but there is one more place referencing CMAKE_BUILD_TOOL
> in tools/llvm-config/CMakeLists.txt:
>> +    COMMAND ${CMAKE_BUILD_TOOL} llvm-config
> That should be able to use the "cmake --build" approach too.
> Thanks,
> -Brad

More information about the llvm-commits mailing list