[llvm] r216345 - X86 intrinsics table - simplifies intrinsics lowering.

Juergen Ributzka juergen at apple.com
Wed Sep 3 00:06:37 PDT 2014

Hi Elena,

sorry about the confusion. My comments where regarding the original commit, which showed up as culprit during a bisect.

I took a quick look at the patch and I think it will solve the problem. But after reading the other comments so far it seems that the
use of a static array is preferred over the std::map.

Adam mentioned that MIPS does something similar with Mips16IntrinsicHelper.

I think a new patch without std::map would be greatly appreciated :)



> On Sep 2, 2014, at 11:15 PM, Demikhovsky, Elena <elena.demikhovsky at intel.com> wrote:
> But this patch solves the problem. I removed globals from the header file. Can I commit it or I should look for another solution?
> -           Elena
> From: Juergen Ributzka [mailto:juergen at apple.com <mailto:juergen at apple.com>] 
> Sent: Tuesday, September 02, 2014 23:37
> To: Demikhovsky, Elena
> Cc: Sean Silva; David Blaikie; LLVM Commits
> Subject: Re: [llvm] r216345 - X86 intrinsics table - simplifies intrinsics lowering.
> Hi Elena,
> this change broke concurrent compilation for us. I looks like the globals (in a header file???) IntrWithChainMap and IntrWithoutChainMap are not guarded against multiple and concurrent initialization.
> Could you please take a look?
> Thanks
> Cheers,
> Juergen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140903/d7fd70b5/attachment.html>

More information about the llvm-commits mailing list