[llvm] r216981 - [CFLAA] LLVM_CONSTEXPR -> const

Juergen Ributzka juergen at apple.com
Tue Sep 2 15:40:16 PDT 2014


Hi Hal,

I see now the following warning:
lib/Analysis/StratifiedSets.h:689:53: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
  bool inbounds(StratifiedIndex N) const { return N >= 0 && N < Links.size(); }

-Juergen


On Sep 2, 2014, at 3:26 PM, Hal Finkel <hfinkel at anl.gov> wrote:

> Author: hfinkel
> Date: Tue Sep  2 17:26:06 2014
> New Revision: 216981
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=216981&view=rev
> Log:
> [CFLAA] LLVM_CONSTEXPR -> const
> 
> The number is just a constant, and this should make MSVC happy (or at least
> happier).
> 
> Modified:
>    llvm/trunk/lib/Analysis/StratifiedSets.h
> 
> Modified: llvm/trunk/lib/Analysis/StratifiedSets.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/StratifiedSets.h?rev=216981&r1=216980&r2=216981&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Analysis/StratifiedSets.h (original)
> +++ llvm/trunk/lib/Analysis/StratifiedSets.h Tue Sep  2 17:26:06 2014
> @@ -38,7 +38,7 @@ struct StratifiedInfo {
> // The number of attributes that StratifiedAttrs should contain. Attributes are
> // described below, and 32 was an arbitrary choice because it fits nicely in 32
> // bits (because we use a bitset for StratifiedAttrs).
> -static LLVM_CONSTEXPR unsigned NumStratifiedAttrs = 32;
> +static const unsigned NumStratifiedAttrs = 32;
> 
> // These are attributes that the users of StratifiedSets/StratifiedSetBuilders
> // may use for various purposes. These also have the special property of that
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list