[PATCH] cmake: Remove check for files not in build list.

Chandler Carruth chandlerc at gmail.com
Tue Sep 2 12:52:51 PDT 2014

Please commit with the condition rewritten as suggested or something similar (provided that you test it works, I didn't try out my cmake scribble here).

Comment at: cmake/modules/LLVMProcessSources.cmake:66
@@ +65,3 @@
+    string(SUBSTRING ${fn} 0 1 first_char)
+    if(NOT ${first_char} STREQUAL ".")
+      list(FIND LLVM_OPTIONAL_SOURCES ${fn} idx)
While regexs are a bit heavy handed, i think this is simpler as:

  if (NOT "${fn}" MATCHES "^\.")

Otherwise, this looks fine.


More information about the llvm-commits mailing list