[PATCH] Implement getNoopForMachoTarget for SPARC

Brad Smith brad at comstyle.com
Mon Sep 1 18:25:58 PDT 2014


On Mon, Sep 01, 2014 at 11:52:34AM -0700, Venkatraman Govindaraju wrote:
> LGTM. Please commit.
> 
> One minor comment for the testcase: Why FP suffix for the
> -check-prefix in the test case? Also, Use CHECK-FP-LABEL instead of
> CHECK-FP to match the function name in the test case for better error
> messages.
> 
> Thanks,
> Venkat
 
Like so?


Index: empty-functions.ll
===================================================================
--- empty-functions.ll	(revision 0)
+++ empty-functions.ll	(working copy)
@@ -0,0 +1,8 @@
+; RUN: llc < %s -mtriple=sparc-unknown-openbsd -disable-fp-elim | FileCheck -check-prefix=CHECK-FP-LABEL %s
+
+define void @func() {
+entry:
+  unreachable
+}
+; CHECK-FP-LABEL:      {{_?}}func:
+; CHECK-FP-LABEL: nop {{[;!]}} avoids zero-length function

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.




More information about the llvm-commits mailing list