[patch] Delete dead code in lib/ProfileData
mail at justinbogner.com
Mon Sep 1 17:07:46 PDT 2014
Rafael Espíndola <rafael.espindola at gmail.com> writes:
> A code review recently found a bug that in my patch in a change it
> made to lib/ProfileData. I was surprised that no test found it. On a
> closer look I realized the code was dead.
> Normally I would just delete it, but since this is a fairly new
> library this might have been just an oversight.
> Is this something that should be in use by tools/llvm-profdata? If it
> instead it is something that is intended for future use, it is
> probably a good idea to delete it for now and bring it back when it is
> actually used.
Sorry, I'm a bit behind on -commits and didn't notice this earlier.
Looks like this work went in before it started getting any use for some
reason. It is used as of r216300, so this patch no longer applies. Sorry
for the trouble.
More information about the llvm-commits