[llvm] r216789 - Omit DW_AT_artificial, DW_AT_external, and similar attributes under -gmlt

[David Blaikie]

(this was accidentally committed and has been reverted - see the llvm-dev
thread discussing line tables)

/maybe/ - but at the moment I'm inclined to remove it unless there's
someone with a concrete use case. I think actually, now that you've fixed
the artificial stuff, we probably don't emit it from the frontend under
-gmlt anyway, though I haven't checked.


On Fri, Aug 29, 2014 at 4:35 PM, Adrian Prantl <aprantl at apple.com> wrote:

> I think DW_AT_artificial could be useful to keep for subprograms, so
> compiler-generated helper functions/thunks can be hidden in backtraces?
>
> -- adrian
>
> > On Aug 29, 2014, at 3:05 PM, David Blaikie <dblaikie at gmail.com> wrote:
> >
> > Author: dblaikie
> > Date: Fri Aug 29 17:05:29 2014
> > New Revision: 216789
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=216789&view=rev
> > Log:
> > Omit DW_AT_artificial, DW_AT_external, and similar attributes under -gmlt
> >
> > Modified:
> >    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
> >
> > Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=216789&r1=216788&r2=216789&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp (original)
> > +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp Fri Aug 29 17:05:29
> 2014
> > @@ -1518,6 +1518,9 @@ void DwarfUnit::applySubprogramAttribute
> >     constructSubprogramArguments(SPDie, Args);
> >   }
> >
> > +  if(getCUNode().getEmissionKind() == DIBuilder::LineTablesOnly)
> > +    return;
> > +
> >   if (SP.isArtificial())
> >     addFlag(SPDie, dwarf::DW_AT_artificial);
> >
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140829/4cecef0f/attachment.html>