[PATCH] [asan-asm-instrumentation] Prologue and epilogue are moved out from InstrumentMemOperand().

Yuri Gorshenin ygorshenin at chromium.org
Fri Aug 29 07:53:24 PDT 2014


Many thanks!

================
Comment at: lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp:552
@@ +551,3 @@
+
+  virtual void InstrumentMemOperandEpilogue(unsigned AccessSize,
+                                            const RegisterContext &RegCtx,
----------------
eugenis wrote:
> Is it possible to remove accesssize argument here and in prologue, and instead pass an invalid/zero value for the scratch register?
> And check in instrumentmemoperandsmall that a scratch register is available, for sanity.
> 
Done.

http://reviews.llvm.org/D4923






More information about the llvm-commits mailing list