[PATCH] Verifier: Don't reject varargs callee cleanup functions

Nick Lewycky nlewycky at google.com
Thu Aug 28 13:16:53 PDT 2014

Hunh. I'd think I'd prefer it if the verifier could check that the function defined callee cleanup and variadic doesn't return (unless the return is a musttail). I dislike making musttail even more special, but I think I just have to learn to deal with it.

Comment at: lib/Target/X86/X86ISelLowering.cpp:3550
@@ -3552,4 +3549,3 @@
     return false;
   case CallingConv::X86_StdCall:
   case CallingConv::X86_FastCall:
Isn't there a fallthrough annotation or comment to use here?


More information about the llvm-commits mailing list