[PATCH] Don't Promote x86_fp80 byval Pointer Arguments

[Reid Kleckner]

Last round of nits, I promise.

================
Comment at: lib/Transforms/IPO/ArgumentPromotion.cpp:130
@@ -127,1 +129,3 @@
 
+// hasPadding - This method checks to see if a type could have padding bytes
+bool ArgPromotion::isDenselyPacked(Type *type) {
----------------
This function changed names. I think these days we just use \brief, @brief, or nothing for doxygen comments.

================
Comment at: lib/Transforms/IPO/ArgumentPromotion.cpp:130
@@ -127,1 +129,3 @@
 
+// hasPadding - This method checks to see if a type could have padding bytes
+bool ArgPromotion::isDenselyPacked(Type *type) {
----------------
rnk wrote:
> This function changed names. I think these days we just use \brief, @brief, or nothing for doxygen comments.
This sentence and others should end in a full stop.

================
Comment at: lib/Transforms/IPO/ArgumentPromotion.cpp:165
@@ +164,3 @@
+
+/// canPaddingBeRead - This method checks to see if the padding bytes of an
+/// argument could be accessed.
----------------
ditto

================
Comment at: test/Transforms/ArgumentPromotion/fp80.ll:39
@@ +38,3 @@
+
+; CHECK: define internal i64 @AccessPaddingOfStruct(%struct.Foo*
+define internal i64 @AccessPaddingOfStruct(%struct.Foo* byval %a) {
----------------
Can we check for the whole prototype? I want to know if we remove byval in this case.

http://reviews.llvm.org/D5057