[llvm] r216605 - Convert a few more cases of direct intialization of unique_ptrs from MemoryBuffer::getMemBuffer to move initialization now that it returns by unique_ptr instead of raw pointer.

[Rafael Espíndola]

Thanks!

On 27 August 2014 16:14, David Blaikie <dblaikie at gmail.com> wrote:
> Author: dblaikie
> Date: Wed Aug 27 15:14:18 2014
> New Revision: 216605
>
> URL: http://llvm.org/viewvc/llvm-project?rev=216605&view=rev
> Log:
> Convert a few more cases of direct intialization of unique_ptrs from MemoryBuffer::getMemBuffer to move initialization now that it returns by unique_ptr instead of raw pointer.
>
> Cleanup/improvements following r216583.
>
> Modified:
>     llvm/trunk/tools/gold/gold-plugin.cpp
>     llvm/trunk/unittests/Support/LineIteratorTest.cpp
>     llvm/trunk/unittests/Support/SpecialCaseListTest.cpp
>
> Modified: llvm/trunk/tools/gold/gold-plugin.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=216605&r1=216604&r2=216605&view=diff
> ==============================================================================
> --- llvm/trunk/tools/gold/gold-plugin.cpp (original)
> +++ llvm/trunk/tools/gold/gold-plugin.cpp Wed Aug 27 15:14:18 2014
> @@ -546,8 +546,8 @@ getModuleForFile(LLVMContext &Context, c
>    if (get_view(F.handle, &View) != LDPS_OK)
>      message(LDPL_FATAL, "Failed to get a view of file");
>
> -  std::unique_ptr<MemoryBuffer> Buffer(MemoryBuffer::getMemBuffer(
> -      StringRef((char *)View, File.filesize), "", false));
> +  std::unique_ptr<MemoryBuffer> Buffer = MemoryBuffer::getMemBuffer(
> +      StringRef((char *)View, File.filesize), "", false);
>
>    if (release_input_file(F.handle) != LDPS_OK)
>      message(LDPL_FATAL, "Failed to release file information");
>
> Modified: llvm/trunk/unittests/Support/LineIteratorTest.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/LineIteratorTest.cpp?rev=216605&r1=216604&r2=216605&view=diff
> ==============================================================================
> --- llvm/trunk/unittests/Support/LineIteratorTest.cpp (original)
> +++ llvm/trunk/unittests/Support/LineIteratorTest.cpp Wed Aug 27 15:14:18 2014
> @@ -17,9 +17,9 @@ using namespace llvm::sys;
>  namespace {
>
>  TEST(LineIteratorTest, Basic) {
> -  std::unique_ptr<MemoryBuffer> Buffer(MemoryBuffer::getMemBuffer("line 1\n"
> -                                                                  "line 2\n"
> -                                                                  "line 3"));
> +  std::unique_ptr<MemoryBuffer> Buffer = MemoryBuffer::getMemBuffer("line 1\n"
> +                                                                    "line 2\n"
> +                                                                    "line 3");
>
>    line_iterator I = line_iterator(*Buffer), E;
>
> @@ -68,11 +68,11 @@ TEST(LineIteratorTest, CommentSkipping)
>  }
>
>  TEST(LineIteratorTest, BlankSkipping) {
> -  std::unique_ptr<MemoryBuffer> Buffer(MemoryBuffer::getMemBuffer("\n\n\n"
> -                                                                  "line 1\n"
> -                                                                  "\n\n\n"
> -                                                                  "line 2\n"
> -                                                                  "\n\n\n"));
> +  std::unique_ptr<MemoryBuffer> Buffer = MemoryBuffer::getMemBuffer("\n\n\n"
> +                                                                    "line 1\n"
> +                                                                    "\n\n\n"
> +                                                                    "line 2\n"
> +                                                                    "\n\n\n");
>
>    line_iterator I = line_iterator(*Buffer), E;
>
> @@ -91,7 +91,7 @@ TEST(LineIteratorTest, BlankSkipping) {
>  }
>
>  TEST(LineIteratorTest, EmptyBuffers) {
> -  std::unique_ptr<MemoryBuffer> Buffer(MemoryBuffer::getMemBuffer(""));
> +  std::unique_ptr<MemoryBuffer> Buffer = MemoryBuffer::getMemBuffer("");
>    EXPECT_TRUE(line_iterator(*Buffer).is_at_eof());
>    EXPECT_EQ(line_iterator(), line_iterator(*Buffer));
>
>
> Modified: llvm/trunk/unittests/Support/SpecialCaseListTest.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/SpecialCaseListTest.cpp?rev=216605&r1=216604&r2=216605&view=diff
> ==============================================================================
> --- llvm/trunk/unittests/Support/SpecialCaseListTest.cpp (original)
> +++ llvm/trunk/unittests/Support/SpecialCaseListTest.cpp Wed Aug 27 15:14:18 2014
> @@ -18,7 +18,7 @@ namespace {
>  class SpecialCaseListTest : public ::testing::Test {
>  protected:
>    SpecialCaseList *makeSpecialCaseList(StringRef List, std::string &Error) {
> -    std::unique_ptr<MemoryBuffer> MB(MemoryBuffer::getMemBuffer(List));
> +    std::unique_ptr<MemoryBuffer> MB = MemoryBuffer::getMemBuffer(List);
>      return SpecialCaseList::create(MB.get(), Error);
>    }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits