[PATCH] [x86] Make vector legalization of extloads work more like the "normal" vector operation legalization with support for custom target lowering and fallback to expand when it fails, and use this to implement sext and anyext load lowering for x86 in a...

Chandler Carruth chandlerc at gmail.com
Wed Aug 27 04:49:15 PDT 2014

On Tue, Aug 26, 2014 at 10:04 AM, Zinovy Nis <zinovy.nis at gmail.com> wrote:

> Sorry for the late comment, but why we need
> ```if (Subtarget->is64Bit()) {```
> check? As I remember, instructions like PMOVSXWD are supported even in
> 32-bit mode?
> I'm asking because I have a significant regression on EEMBC1.1 for
> autocorrelation tests due to lots of insert-like generated instructions for
> SLM target under -m32. Removing this check fixes the regression.

The idea behind this was just flawed. It was intending to make sure we
could load 64-bits.... but that is neither what the check means nor
necessary! The code handles 32-bit architectures just fine as you point
out. =] Fixed in r216538.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140827/a185bec6/attachment.html>

More information about the llvm-commits mailing list