[PATCH] Make the plugin loader limit its symbol search to the specified module.

Reid Kleckner rnk at google.com
Tue Aug 26 15:31:13 PDT 2014


================
Comment at: include/llvm/Support/DynamicLibrary.h:48
@@ -45,2 +47,3 @@
 
-    explicit DynamicLibrary(void *data = &Invalid) : Data(data) {}
+    llvm::SmallString<128> Filename;
+
----------------
It looks like DynamicLibrary is supposed to be a thin value type wrapper around native library handles. Adding this string makes it no longer trivially copyable and blows out its size. If we really need this, I think we should delete the copy ctor and eliminate the places where we pass it around by value.

http://reviews.llvm.org/D5030






More information about the llvm-commits mailing list