[patch] Pass a MemoryBufferRef when we can avoid taking ownership

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Aug 26 15:26:27 PDT 2014

> Actually I did mean && - it's not uncommon for APIs to take by movement then
> fail to move-from in their failure path. Granted in the C++ standard library
> that failure is demonstrated by throwing an exception, whereas this has a
> return result.

OK, so this patch (on top of all previous which were already
committed) changes the & to &&. I personally find a
"foo(std::move(bar))" that doesn't always move bar to be a bit
confusing, but if that is common, I am OK with it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 6584 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140826/14d2e647/attachment.bin>

More information about the llvm-commits mailing list