[PATCH] [ASan/Win] Add an extra thunk.lib to handle stack-use-after-return option

Timur Iskhodzhanov timurrrr at google.com
Tue Aug 26 03:19:02 PDT 2014


Comment at: compiler-rt/trunk/lib/asan/asan_uar_thunk.cc:1
@@ +1,2 @@
+//===-- asan_uar_thunk.cc -------------------------------------------------===//
samsonov wrote:
> Consider clarifying that this is Windows-specific file in the filename.
Good idea!
I've made it `asan_win_uar_thunk.cc`, I'll also rename `asan_dll_thunk.cc` to `asan_win_dll_thunk.cc` in a separate change for consistency.

Please note that I've intentionally left the `.lib` filename unchanged as it doesn't make sense to put `win` in there.

Comment at: compiler-rt/trunk/lib/asan/asan_uar_thunk.cc:30
@@ +29,2 @@
+#endif // ASAN_DLL_THUNK
samsonov wrote:
> wrong comment
Good catch -- thanks!


More information about the llvm-commits mailing list