[PATCH] [Support] Windows - Refactor argument serialization logic when executing process in Program.inc [NFC]

Rafael Auler rafaelauler at gmail.com
Mon Aug 25 13:15:40 PDT 2014


Hi rafael,

This patch refactors the argument serialization logic used in the Execute function, used to launch new Windows processes. There is a critical step that joins char** arguments into a single string, building the command line used to launch the new process, and the readability of this code is improved if this part is refactored in its own helper function.

http://reviews.llvm.org/D5054

Files:
  lib/Support/Windows/Program.inc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5054.12915.patch
Type: text/x-patch
Size: 1679 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140825/f3b3c0d3/attachment.bin>


More information about the llvm-commits mailing list