The patch for FreeBSD headers

Richard Smith richard at metafoo.co.uk
Mon Aug 25 12:36:24 PDT 2014


On Sat, Aug 9, 2014 at 4:17 AM, Ivan A. Kosarev <ikosarev at accesssoftek.com>
wrote:

> Hello Richard,
>
> As of today, the issue with system definitions on FreeBSD 9.2 in 32-bit
> mode addressed by this diff:
>
> http://reviews.llvm.org/D4623
>
> is the only one that prevent us from enabling running (and passing) 32-bit
> tests on the FreeBSD sanitizers buildbot.
>
> Can you please let me know if there is any decision about this patch? Do
> you think we should keep the tests disabled or apply the diff locally or it
> could be altered somehow to be more acceptable?


I do not think it is our job to "fix" partially-implemented OS features.
This patch would take us in a very troubling direction, and it's not clear
that we would ever be able to remove this hack. Please try to find another
way to get the result you desire. If the sanitizers + FreeBSD 9.2 needs
some patch to be applied to the system headers, then that patch should be
provided by FreeBSD or possibly by the sanitizers, and *not* by the
compiler.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140825/2dfd9a0d/attachment.html>


More information about the llvm-commits mailing list