[llvm] r216391 - [x86] Fix a bug in r216319 where I was missing a 'break'.
chandlerc at gmail.com
Mon Aug 25 11:06:11 PDT 2014
Date: Mon Aug 25 13:06:11 2014
New Revision: 216391
[x86] Fix a bug in r216319 where I was missing a 'break'.
This actually was caught by existing tests but those tests were disabled
with an XFAIL because of PR20736. While working on fixing that,
I noticed the test failure, and tracked it down to this.
We even have a really nice Clang warning that would have caught this but
it isn't enabled in LLVM! =[ I may look at enabling it.
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Mon Aug 25 13:06:11 2014
@@ -19467,11 +19467,13 @@ combineRedundantDWordShuffle(SDValue N,
V = DAG.getNode(W.getOpcode(), DL, W.getValueType(), V, V);
V = DAG.getNode(W.getOpcode(), DL, W.getValueType(), V, W.getOperand(1));
if (V.getValueType() != N.getValueType())
More information about the llvm-commits