[PATCH] [AArch32] Added patterns for VCVT{A,N, P,M}.

Renato Golin renato.golin at linaro.org
Mon Aug 25 04:50:31 PDT 2014

>>! In D5033#4, @compnerd wrote:
> I think that you should add a bit more test coverage though.  The hard float shouldn't matter towards use of these instructions.  So, I think you should also test gnueabi.

Shouldn't matter, but adding won't hurt either. Is VCVTN tested elsewhere?

> Furthermore, I believe that these instructions are also available on non-v8 hardware if you have a NEON FPU.  So, it may be nice to also add cases for armv7 with neon on hard float and soft float.

AFAIK, VCVT with user rounding in ARMv7 can only be done via the FPSCR, which is not the same thing here (and will need more code if there isn't already). These tests are clearly for v8, so I'm fine with it the way it is.



More information about the llvm-commits mailing list