[PATCH] [AArch32] Added patterns for VCVT{A,N, P,M}.

Saleem Abdulrasool compnerd at compnerd.org
Sun Aug 24 13:30:50 PDT 2014


First, thanks for adding these.

The changes to the table data looks fine.

I think that you should add a bit more test coverage though.  The hard float shouldn't matter towards use of these instructions.  So, I think you should also test gnueabi.  Furthermore, I believe that these instructions are also available on non-v8 hardware if you have a NEON FPU.  So, it may be nice to also add cases for armv7 with neon on hard float and soft float.  The tests would be identical in those cases, simply a matter of adding the appropriate RUN lines.

http://reviews.llvm.org/D5033






More information about the llvm-commits mailing list