[llvm] r216346 - This code is from r216285, which did not go out to the mailing list for some reason.

Aaron Ballman aaron at aaronballman.com
Sun Aug 24 06:25:18 PDT 2014


Author: aaronballman
Date: Sun Aug 24 08:25:16 2014
New Revision: 216346

URL: http://llvm.org/viewvc/llvm-project?rev=216346&view=rev
Log:
This code is from r216285, which did not go out to the mailing list for some reason.

The switch statement would never fire due to the preceding break statement. Also, the switch statement has a default label with no case labels. Simplified the code, and allow it to execute.

Modified:
    llvm/trunk/tools/llvm-objdump/MachODump.cpp

Modified: llvm/trunk/tools/llvm-objdump/MachODump.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/MachODump.cpp?rev=216346&r1=216345&r2=216346&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-objdump/MachODump.cpp (original)
+++ llvm/trunk/tools/llvm-objdump/MachODump.cpp Sun Aug 24 08:25:16 2014
@@ -1036,12 +1036,7 @@ static void PrintMachHeader(uint32_t mag
       break;
     case MachO::CPU_SUBTYPE_X86_64_H:
       outs() << "    Haswell";
-      break;
-      switch (cpusubtype & ~MachO::CPU_SUBTYPE_MASK) {
-      default:
-        outs() << format(" %10d", cpusubtype & ~MachO::CPU_SUBTYPE_MASK);
-        break;
-      }
+      outs() << format(" %10d", cpusubtype & ~MachO::CPU_SUBTYPE_MASK);
       break;
     case MachO::CPU_TYPE_ARM:
       outs() << "     ARM";





More information about the llvm-commits mailing list