[llvm] r216338 - Support: add llvm::unique_lock

Chandler Carruth chandlerc at google.com
Sat Aug 23 17:45:18 PDT 2014


On Sat, Aug 23, 2014 at 4:07 PM, Dylan Noblesmith <nobled at dreamwidth.org>
wrote:

> Support: add llvm::unique_lock
>
> Based on the STL class of the same name, it guards a mutex
> while also allowing it to be unlocked conditionally before
> destruction.
>

I didn't notice this in the pre-commit review (the subject didn't really
make it clear what you were planning on), but why do we need our own? Why
can't we use std::unique_lock? I'm sure there is some reason, but I'm
pretty sure it is a bug and not a feature and I'm somewhat opposed to us
adding this kind of thing just to remove it later rather than fixing the
underlying problems so that we can use std::unique_lock....
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140823/092a7c1b/attachment.html>


More information about the llvm-commits mailing list