[llvm] r215862 - ARM: improve RTABI 4.2 conformance on Linux

Renato Golin renato.golin at linaro.org
Thu Aug 21 05:30:24 PDT 2014


On 21 August 2014 13:19, Moritz Roth <moritz.roth at arm.com> wrote:
> If I change the check on line 718 to something like
>         if (!isTargetAEABI() && !isTargetGNUEABI()) {
> and define isTargetGNUEABI in the obvious way in ARMSubtarget.h,
> the custom lowering is used for GNUEABI as well and the failures seem
> to go away.

I think this is just coincidence. I'll have a better look at the code...


> This is sort of a wild guess, but I think the proper way to fix this is
> described in ARMSubtarget.h, where isTargetAEABI is defined:

Yes, that's the best way to fix this, but it'll take a while and until
then, divmod will be broken.

cheers,
--renato



More information about the llvm-commits mailing list